Constructive criticism needed please.

khortez · #1 01-21-2012, 12:57 AM

As title says, i am once again looking for peoples thoughts on my code, so any helpful input thank you in advance here is the link:

http://pastebin.graalcenter.org/read...d=821022392520

tell me if it works or not, thank you.

Gunderak · #2 01-21-2012, 01:51 AM

Not a bad start, this

PHP Code:


			
if(this.boots) {

should probably be

PHP Code:


			
if(this.boots == true){

Maybe use on KeyPressed to toggle the windows visibility.
I wrote how to do that but incapsula blocked it and I lost all my writing -_-
I effing hate incapsula.

ffcmike · #3 01-21-2012, 01:53 AM

Quote:

Originally Posted by Gunderak

Not a bad start, this

PHP Code:


			
if(this.boots) {

should probably be

PHP Code:


			
if(this.boots == true){

Probably?

If this.boots is true, his way would essentially be doing:

PHP Code:


			
if(true){

  //stuff

}

Which is basically what if(condition){} is for.

Skyld · #4 01-21-2012, 02:22 AM

Quote:

Originally Posted by Gunderak

should probably be

PHP Code:


			
if(this.boots == true){

if (this.boots == true) is equivalent to if (true == true) or if (false == true), which is unnecessary, since the expression inside the brackets only needs to evaluate to true anyway. if (this.boots) is fine.

cbk1994 · #5 01-21-2012, 06:44 PM

The only thing I notice is the naming of the GUI controls. The names look unlikely to result in collisions with other scripts, but I'd recommend naming all controls with the same prefix as the parent (e.g. Staff_Window, everything below is named Staff_BootsButton, etc). If you don't do this it can be easy for names to conflict and cause issues.