Instrument trouble...

[RavenofEarth]

Now, this has to be the easiest script, and I seem to be having a minor issue with it. The sounds don't seem to be playing when I press the corresponding keys, the sounds all work, I am unsure if I am overlooking something, or what.

NPC Code:

---

//#CLIENTSIDE

if (weaponfired) {

setani anzell_flute,anzell-flute.png;

disabledefmovement;

}

if (strequals(#m,anzell_flute)) {

if (keydown(6)) enabledefmovement;

if (keydown(5)) {

if (keydown(0)) play fire2.wav;

elseif (keydown(1)) play flute2.wav;

elseif (keydown(2)) play flute3.wav;

elseif (keydown(3)) play flute4.wav;

} else {

if (keydown(0)) play flute5.wav;

elseif (keydown(1)) play flute6.wav;

elseif (keydown(2)) play flute7.wav;

elseif (keydown(3)) play flute8.wav;

}

}

---

If anyone has any suggestions on a better script, notify me...XD

[Lance]

Please read this thread and stop putting code outside of event blocks.

[RavenofEarth]

O_o Uhh, I still don't see what that's supposed to be telling me about the event block O_o

[Lance]

Originally Posted by RavenofEarth

O_o Uhh, I still don't see what that's supposed to be telling me about the event block O_o

You didn't read the thread. Please try again.

Pay special attention to the definitions of "code block", "event block", and Kai's Rule One.

[RavenofEarth]

Uh, I read the thread...Yet, I am still confuzzled about what it's trying to convey.

[Lance]

Originally Posted by RavenofEarth

Uh, I read the thread...Yet, I am still confuzzled about what it's trying to convey.

What part of those I referenced do you not understand?

[CheeToS2]

Originally Posted by RavenofEarth

O_o Uhh, I still don't see what that's supposed to be telling me about the event block O_o

The problem is that everything after the 'weaponfired' block in your script is not in an event block, so Graal is not sure when it is supposed to check if your gani is set to anzell_flute or if a certain key is being pressed; maybe it should check when it detects that any key has been pressed, or maybe it should check when you type some words in the chat box. Perhaps you want it to check if the 'up' key is pressed when the United States decides to adopt Graal's Terms of Service as its new constitution; nobody knows when it should check, because you have not specified any event that tells it when.

Events are things that can happen, like the weapon being fired (weaponfired), the npc being touched (playertouchsme), or a timeout occuring (you could set timeout = .05, and .05 seconds later the "timeout" event occurs); there are many others. In your case, you probably want to use the 'timeout' or 'keypressed' events (keypressed might only work in v4 for what you want it to do, I don't think v2 will call keypressed for the arrow keys).

[Yen]

Style your scripts.
You should use a gani that plays the sound, instead of the 'play' command.
The 'play' command only plays the sound to you, not other players.
Using a gani will play the sound for everyone.

PHP Code:

if (event) {
  command;
  command;
  if (condition) {
    command;
    command;
  }
}