weapon not working

[excaliber7388]

this is a big script, and I'm haiving trouble finding it's problems. Since i'm not posting the full script, assume that all variables and strings are accounted for. The problem is, when I click, nothing happens, and the target doesn't follow the mouse.

NPC Code:

---

if(weaponfired && playermp>(20-strtofloat(#s(clientr.divine_skill))))

{

  timeout=.05;

  //stuff

  if(strtofloat(#s(clientr.divine_mode))==1)

  {

    //stuff

    if(playerdir==0)

    {

      for(this.i=2;this.i<20;this.i++)

      {

        showimg 0,dr-divine_light_attack.png,playerx+.5,playery-this.i;

        changeimgpart 0,34,0,32,32;

        hitobjects strtofloat(#s(clientr.divine_attack)),playerx+.5,p  layery-this.i;

        sleep .05;

      }

    }

    else if(playerdir==2)

    {

      for(this.i=2;this.i<20;this.i++)

      {

        //stuff

      }

    }

    else if(playerdir==1)

    {

      for(this.i=0;this.i<20;this.i++)

      {

//stuff

      }

    }

    else if(playerdir==3)

    {

      for(this.i=2;this.i<20;this.i++)

      {

        //stuff

      }

    }

    hideimg 0;

  }

  if(strtofloat(#s(clientr.divine_mode))==2 || timeout)

  {

    //stuff

    showimg 300,dr-crosshairs.png,mousex-.5,mousey-.5;

      if(mousedown && leftmousebutton)

      {

        //stuff

        for(this.i=0;this.i<this.c+1;this.i++)

        {

         //stuff

         {

           //stuff

           {

             //stuff

           }

           if(this.y>mousey)

           {

             //stuff

           }

          }

         if(this.x>mousex)

         {

           //stuff

           if(this.y<mousey)

           {

             //stuff

           if(this.y>mousey)

           {

             //stuff

           }

         }

         if(this.y<mousey)

         {

           //stuff

           if(this.x<mousex)

           {

             //stuff

           }

           if(this.x>mousex)

           {

             //stuff

           }

         }

         if(this.y>mousey)

         {

           //stuff

           if(this.x<mousex)

           {

             //stuff

           }

           if(this.x>mousex)

           {

             //stuff

           }

         }

         //stuff

         sleep .05;

        }

       }

      if(isweapon && this.inuse==1 && keypressed && strequals(#p(1),A))

      {

        hideimg 300;

        this.inuse=0;

        timeout=0;

      }

      timeout=.05;

  }



  //stuff

}

---

[ZeLpH_MyStiK]

Read your other threads please.
Do not confuse events with booleans.
keypressed is an event.
weaponfired is an event.
this.var == 1 is a boolean.
playermp > 20 is a boolean.

[excaliber7388]

I simplified it a bit. When you fire the weapon, the character freezes, clicking and A do nothing, and the fire appears, but does not follow

NPC Code:

---

if(weaponfired)

{

  //stuff

 if(strtofloat(#s(clientr.divine_mode))==2 || timeout && strtofloat(#s(clientr.divine_mode))==2)

  {

    //stuff

    this.inuse=1;

    if(this.inuse==1 ||timeout && this.inuse==1)

    {

      showimg 300,fire.gif,mousex,mousey;

      timeout=.05;

    }

    

    if(mousedown && this.inuse==1)

    {

      putexplosion 1,mousex,mousey;

      enabledefmovement;

    }

    if(keypressed && strequals(#p(1),A))

    {

      hideimg 300;

      timeout=0;

      this.inuse=0;

      enabledefmovement;

    }

  }

}

---

[ZeLpH_MyStiK]

Read my post -.-

Originally Posted by ZeLpH_MyStiK

Read your other threads please.
Do not confuse events with booleans.
keypressed is an event.
weaponfired is an event.
this.var == 1 is a boolean.
playermp > 20 is a boolean.

[excaliber7388]

got it, but now i have a new problem: this part doesn't work

NPC Code:

---

for(this.i=0;this.i<this.c+1;this.i++)

      {

        if(this.x<this.mousex)

        {

          this.x++;

          if(this.y<this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,0,32,32;

          }

          else if(this.y>this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,68,32,32;

          }

        }

        else if(this.x>this.mousex)

        {

          this.x--;

          if(this.y<this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,0,32,32;

          }

          else if(this.y>this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,68,32,32;

          }

        }

        else if(this.y<this.mousey)

        {

          this.y++;

          if(this.x<this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,68,32,32;

          }

          else if(this.x>this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,0,0,32,32;

          }

        }

        else if(this.y>this.mousey)

        {

          this.y--;

          if(this.x<this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,68,68,32,32;

          }

          else if(this.x>this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.x,this.y;

            changeimgpart 0,0,0,32,32;

          }

        }

        sleep .05;

      }

---

[ZeLpH_MyStiK]

We do not know what those variables are, please clarify.

[excaliber7388]

Originally Posted by ZeLpH_MyStiK

We do not know what those variables are, please clarify.

Good point XD
this.x and this.y are the coordinates of the showimg
this.playerx and this.playery are the players coordinates when the weapon is fired
this.mousex and this.mousey are the coordinates of the mouse when the weapon is fired

[ApothiX]

At a quick glance, you should not be using this.x and this.y as variables, especially if you intend on having the new engine enabled some day.

[Damix2]

Originally Posted by ApothiX

At a quick glance, you should not be using this.x and this.y as variables, especially if you intend on having the new engine enabled some day.

Yes, ran into many problems with that.

They are reserved.

[excaliber7388]

Originally Posted by Damix2

Yes, ran into many problems with that.

They are reserved.

Ouch i'll chsnge them. GS2 is enabled on DR, could this be a reason it doesn't work?

[excaliber7388]

Here's the entire block this is working from

NPC Code:

---

if(mousedown && this.inuse==1 && leftmousebutton)

    {

      mousex=this.mousex;

      mousey=this.mousey;

      this.playerx=playerx;

      this.playery=playery;

      this.px=playerx;

      this.py=playery;

      this.x2=abs(this.mousex-this.playerx);

      this.c=(this.px^2+this.py^2)^.25;

      hitobjects strtofloat(#s(clientr.divine_attack)),mousex-.5,mousey-.5;

      hitobjects strtofloat(#s(clientr.divine_attack)),mousex+.5,mo  usey+.5;

      hitobjects strtofloat(#s(clientr.divine_attack)),mousex,mouse  y;

      for(this.i=0;this.i<this.c;this.i++)

      {

        if(this.px<this.mousex)

        {

          this.px++;

          if(this.py<this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,0,32,32;

          }

          if(this.py>this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,68,32,32;

          }

        }

        if(this.px>this.mousex)

        {

          this.px--;

          if(this.py<this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,0,32,32;

          }

          if(this.py>this.mousey)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,68,32,32;

          }

        }

        if(this.py<this.mousey)

        {

          this.py++;

          if(this.px<this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,68,32,32;

          }

           if(this.px>this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,0,0,32,32;

          }

        }

         if(this.py>this.mousey)

        {

          this.py--;

          if(this.px<this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,68,68,32,32;

          }

          if(this.px>this.mousex)

          {

            showimg 0,dr-divine_light_attack.png,this.px,this.py;

            changeimgpart 0,0,0,32,32;

          }

        }

        sleep .05;

      }

      enabledefmovement;

      triggeraction 0,0,serverside,Divine Light,exp_gaining;

      triggeraction 0,0,serverside,Divine Light,mp;

      hideimg 300;

      hideimg 0;

      this.inuse=0;

    }

---

[ZeLpH_MyStiK]

Now another problem you have is that you're now trying to set your mouse coordinates with:
mousex=this.mousex;
mousey=this.mousey;
which is not possible.

[excaliber7388]

wow brain fart.
Anyway, the images dont work though, they're messed up, and don't point in the right directions

[ZeLpH_MyStiK]

Then there's something wrong with the execution of this script. I suggest you run through this script once by hand and see where it isn't doing what you want it to do.

[excaliber7388]

fixed the above, here's the next problem. They don't always point in the right direction
(for the changeimgpart: 24,0 is up 34,68 is down 0,34 is left 68,34 is right)

NPC Code:

---

if(this.px>this.mousex-2 && this.px<this.mousex+4 && this.py>this.mousey)

        {

          changeimgpart 0,34,0,32,32;

        }

        if(this.px>this.mousex-2 && this.px<this.mousex+4 && this.py<this.mousey)

        {

          changeimgpart 0,34,68,32,32;

        }

        if(this.py>this.mousey-1 && this.py<this.mousey+3 && this.px<this.mousex)

        {

          changeimgpart 0,68,34,32,32;

        }

        if(this.py>this.mousey-1 && this.py<this.mousey+3 && this.px>this.mousex)

        {

          changeimgpart 0,0,34,32,32;

        }

---

[Bl0nkt]

You should learn GS2.

It's not as hard as you may think.

[ZeLpH_MyStiK]

I'm getting tired of this. We're not here to create/fix your npc for you. Use some logic.

[excaliber7388]

Originally Posted by ZeLpH_MyStiK

I'm getting tired of this. We're not here to create/fix your npc for you. Use some logic.

Oh well, thanks anyway. I know I can find the problem, i was just hoping another pair of eyes would help me do it quicker.

[ApothiX]

Originally Posted by excaliber7388

Oh well, thanks anyway. I know I can find the problem, i was just hoping another pair of eyes would help me do it quicker.

Then hire some scripters on your server. You have been making a lot of these post, and it is getting really annoying <_<

[Andy0687]

It is no wonder we have no other proficient scripters here

everyone just huddles into their own little world and stays there -.-

[ZeLpH_MyStiK]

Originally Posted by Andy0687

It is no wonder we have no other proficient scripters here

everyone just huddles into their own little world and stays there -.-

And it is no wonder everyone just huddles into their own little world and stays there. -.-

[ApothiX]

Originally Posted by Andy0687

It is no wonder we have no other proficient scripters here

everyone just huddles into their own little world and stays there -.-

Perhaps you should take a look at all the posts made by Excaliber before you go rhyming off blatant accusations. Maybe then, will you see just how much me trys before he posts about a problem.

[Andy0687]

Originally Posted by ApothiX

Perhaps you should take a look at all the posts made by Excaliber before you go rhyming off blatant accusations. Maybe then, will you see just how much me trys before he posts about a problem.

Sorry maybe i was not thinking right when i made my prior post, I cant seem to remember exactily what i was reading/thinking at the time.

I have watched him post a few times about problems, and i re-read this thread and saw how he is posting here.

I guess if you dont help someone they wont ever get better.

I apologize if i came off a bit wrong (which i guess i did).

[excaliber7388]

Originally Posted by ApothiX

Perhaps you should take a look at all the posts made by Excaliber before you go rhyming off blatant accusations. Maybe then, will you see just how much me trys before he posts about a problem.

actually, I was working on this for a few hours before posting, and I fixed it without help I ask because I'm using this on my server, and need it done quickly, as I have 1,000 other things to do as well.

[projectigi]

god
many people said this now
GET SCRIPTERS
they will help you to quickly get your scripts online

[excaliber7388]

Originally Posted by projectigi

god
many people said this now
GET SCRIPTERS
they will help you to quickly get your scripts online

Oh! For my next trick, I pull a scripter out from my hat!! =|

[Admins]

We are working on better documentation and script examples, also working systems you can use for new servers. That should probably help with setting up an interesting invironment?

[ApothiX]

Originally Posted by Stefan

We are working on better documentation and script examples, also working systems you can use for new servers. That should probably help with setting up an interesting invironment?

Hmm, documentation and examples maybe, but working systems I think would just make people more lazy than they already are