triggeraction vs player.trigger

[Tyhm]

Here's the thing - I really, really hate the triggeraction(targetx+1.5,targety+1.5,hit,2); technique. What happens if the target's lagging? What happens if he moves between the point that you had him lined up in your sites and took the shot and the point that the action triggers on his spot?

And yet I find myself with a script that's almost finished - except that the previous scripter used triggeraction. I've got a whole beautiful (not elegant, I don't do elegant) subroutine for detecting which players are about to get hit and storing their names, and I've got a whole beautiful loop for picking each one and hitting them...but because I'm not writing (guessing) it Exactly Right, it doesn't do a damn thing.

Here's what I got:

PHP Code:

//#CLIENTSIDE

function onActionMelee() {
  player.chat=("Hit! "@params[0] SPC params[1]);
  setAni("hurt", "");
  if(this.cooldown<1){
    triggerserver("gui", this.name, "hurt", params[0], params[1]);
    findWeapon("GUIInventory").trigger("showHUD", "");
    this.cooldown=60;
  }
} 


which works fine (but only for triggeraction x y), and

PHP Code:

          with(findplayer(plr)){
            //            echo("Found "@plr SPC ani);
            setAni("hurt", "");
            triggerserver("gui", "#HP", "hurt", "other", temp.dmg);
            this.findWeapon("#HP").trigger("Melee", "other", "3");
            this.findWeapon("#HP").trigger("ActionMelee", "other", "3");
            this.findWeapon("#HP").trigger("OnActionMelee", "other", "3");
            this.findWeapon("#HP").melee("other", "3");
            this.findWeapon("#HP").Melee("other", "3");
            this.findWeapon("#HP").ActionMelee("other", "3");
            this.findWeapon("#HP").actionmelee("other", "3");
            this.findWeapon("#HP").onactionmelee("other", "3");
            this.findWeapon("#HP").OnActionMelee("other", "3");
          } 


(also clientside); to reiterate, isn't there some sort of player.trigger(wossname)?

[cbk1994]

Why are you naming your weapons with a # in front of them, anyway?

Have you debugged and made sure that you're actually reaching the player? It looks like those should work.

Are you getting any errors in NC (e.g. can't access private function)?

If you want I can get on Testbed or wherever you're doing this and try to help you out.

[Tyhm]

I inherited the # signs. Not a lot I can do about it. Got sure I can find it (I forgot some little subroutine to make sure the player was getting called), then the guy I was testing with got quietly kicked offline. Right now I got

PHP Code:

            triggerserver("weapon",this.name,0,temp.sinx,temp.siny,temp.targets,temp.ptargets);
            temp.ptt=ptargets.tokenize();
            player.chat=("PTT:"@ptt);
            for(temp.plrn:ptt){
              temp.plr=findplayer(plrn);
              player.chat=("PLR:"@plr SPC this.damage);
              plr.chat="Fix me";
              triggeraction(plr.x+1.5, plr.y+1.5, "melee", "other", this.damage);
              triggeraction(plr.x+1.5, plr.y+1.5, "tyhm", "other", this.damage);
              triggeraction(plr.x+1.5, plr.y+1.5, "Tyhm", "other", this.damage);
            } 


And it Used to work, but spontaneously stopped. -_-. Curiously, if I comment out the other two triggeractions it works fine...but only out to a certain distance, about 6 tiles. And actionmelee looks like this:

PHP Code:

function onActionMelee() {
  player.chat=("Hit! "@params[0] SPC params[1]);
  setAni("hurt", "");
  if(this.cooldown<1){
    triggerserver("gui", this.name, "hurt", params[0], params[1]);
    findWeapon("GUIInventory").trigger("showHUD", "");
    this.cooldown=60;
  }
} 


[WhiteDragon]

Clientside to clientside triggeractions only work for a certain distance.

If you're trying to make a sort of long range hit detection you may want to change your methods (such as storing the data in attr or anis).

[Tyhm]

Originally Posted by WhiteDragon

Clientside to clientside triggeractions only work for a certain distance.

If you're trying to make a sort of long range hit detection you may want to change your methods (such as storing the data in attr or anis).

...
...
...
...
Thanks, that's great. Hooray Wiki. -_-

Does the old trick of setting a weapon's x and y work? Or is it a fixed distance from the player? Or is a weapon's x and y static?

[WhiteDragon]

Originally Posted by Tyhm

Does the old trick of setting a weapon's x and y work? Or is it a fixed distance from the player? Or is a weapon's x and y static?

I believe Stefan said it was a fixed distance, but you could always try that since he didn't explicitly say what the engine was determining the distance from.

[cbk1994]

Suggestion: Join the player to a class, then you can call a public function.

PHP Code:

findPlayer("cbk1994").doDamage(1); 


Let me know if you need a better explanation.

[Tyhm]

Might do that, the players already join a class; would that trigger function on doDamage(){, function onDoDamage(){, function doDamage(){, ? The "on"s always throw me.

[salesman]

Originally Posted by Tyhm

Might do that, the players already join a class; would that trigger function on doDamage(){, function onDoDamage(){, function doDamage(){, ? The "on"s always throw me.

it's just calling

PHP Code:

public function doDamage() {
  ...
} 


[Tyhm]

kkthxz. :-D

[Codein]

Originally Posted by WhiteDragon

If you're trying to make a sort of long range hit detection you may want to change your methods (such as storing the data in attr or anis).

Thankyou for this suggestion!

[cbk1994]

Originally Posted by Tyhm

Might do that, the players already join a class; would that trigger function on doDamage(){, function onDoDamage(){, function doDamage(){, ? The "on"s always throw me.

"on" is used when you use a trigger.

PHP Code:

npc.trigger("PlayerAttack", player.account, dmg); // calls "onPlayerAttack"
npc.playerAttack(player.account, dmg); // calls "playerAttack" 


The main benefits of using triggers are:

• They don't interrupt your code (your code continues without waiting for the function to finish)
• You can trigger any NPC for any function, and even if it doesn't exist, it won't give an error, unlike directly calling the function.

[Codein]

Originally Posted by cbk1994

"on" is used when you use a trigger.

PHP Code:

npc.trigger("PlayerAttack", player.account, dmg); // calls "onPlayerAttack"
npc.playerAttack(player.account, dmg); // calls "playerAttack" 


The main benefits of using triggers are:

• They don't interrupt your code (your code continues without waiting for the function to finish)
• You can trigger any NPC for any function, and even if it doesn't exist, it won't give an error, unlike directly calling the function.

I, personally, would have liked a trigger to be used for this situation but unfortunately, it didn't work. I don't know if I did something wrong though. However, what I've done to work around the situation works almost as well

[Inverness]

Event function names are prefixed with "on" and trigger() is triggering an event, same with scheduleevent().

I also find "doDamage" a silly function name, "damage" works fine.

[WhiteDragon]

Keep in mind that triggers are considerably slower than direct public function calls. However if you do not need quick response time, triggers/events are much more useful, especially because of the interface they provide with functions such as catchevent.