My crappy fishpole

Spectre1337 · #1 03-26-2002, 07:40 AM

My first ever fishpole, yay!
Tell me what you think or tell what I can do to make it better!

NPC Code:

if (weaponfired&&onwater(playerx-1,playery-1)||onwater(playerx+1,playery+1)||onwater(playerx-1,playery+1)||onwater(playerx+1,playery-1))

  {

  freezeplayer 5;

  setani kick,;

  sleep 1;

  setani kick,;

  sleep 1;

  setani kick,;

  sleep 1;

  setani kick,;

  sleep 1;

  setani kick,;

  sleep 1;

  client.fish+=1;

  setplayerprop #c,I got one!;

  setstring client.fish,#v(client.fish);

}else if (weaponfired){

  setplayerprop #c,On WATER!;

}



if (weaponfired&&#m=swim)

  {

  setplayerprop #c,On WATER!;

}

if (playerchats&&strequals(#c,show fish)){

  setplayerprop #c,You have #v(client.fish) fish(s);

}

haunter · #2 03-26-2002, 07:46 AM

There must be a way to shorten all those onwater flags... im just not sure how... Maybe someone can say and i'll learn something... X>X

screen_name · #3 03-26-2002, 08:09 AM

use the vector or x and y, much easier

BARGAD · #4 03-26-2002, 09:34 AM

Hm, not really,maybe if you use an onboard detector

/CaRnIe

screen_name · #5 03-26-2002, 09:57 AM

works same with onwater

Spectre1337 · #6 03-26-2002, 10:45 AM

I dont even know "vecx" and "vecy".. I dont even know onwater. I had to look in the Commands.rtf.. ha

joseyisleet · #7 03-26-2002, 03:24 PM

-=Josey=-

NPC Code:

if (onwater(playerx+1+vecx(playerdir)*2.5,playery+1.5  +vecy(playerdir)*2.5){}

nyghtGT · #8 03-26-2002, 03:41 PM

Quote:

Originally posted by Spectre1337
My first ever fishpole, yay!
Tell me what you think or tell what I can do to make it better!

NPC Code:
if (weaponfired&&onwater(playerx-1,playery-1)||onwater(playerx+1,playery+1)||onwater(playerx-1,playery+1)||onwater(playerx+1,playery-1))
{
freezeplayer 5;
setani kick,;
sleep 1;
setani kick,;
sleep 1;
setani kick,;
sleep 1;
setani kick,;
sleep 1;
setani kick,;
sleep 1;
client.fish+=1;
setplayerprop #c,I got one!;
setstring client.fish,#v(client.fish);
}else if (weaponfired){
setplayerprop #c,On WATER!;
}

if (weaponfired&&#m=swim)
{
setplayerprop #c,On WATER!;
}
if (playerchats&&strequals(#c,show fish)){
setplayerprop #c,You have #v(client.fish) fish(s);
}

try using arrays ...
and the 'for' command could be used as well ...