Repeating chat?

[Fysez]

I thought maybe this would work

PHP Code:

function onCreated() {
this.chat = "Message1";
if (this.chat = "Message1") {
sleep(3);
this.chat = "Message2";
} else if (this.chat = "Message2") {
sleep(3);
this.chat = "Message1";
}
} 


This only makes the NPC say "Message1" , "Message2". And there it stops.
How can this be fixed up?

[fowlplay4]

You don't need an if statement, just use a timeout.

PHP Code:

function onCreated() {
  onTimeout();
}

function onTimeout() {
  this.chat = "Message1";
  sleep(3);
  this.chat = "Message2";
  setTimer(3);
} 


I'm pretty sure you've been told this before but use 2 equal signs instead of one when you're comparing values. I.e. if (this.variable == 1) { // stuff

[Fysez]

Originally Posted by fowlplay4

You don't need an if statement, just use a timeout.

PHP Code:

function onCreated() {
  onTimeout();
}

function onTimeout() {
  this.chat = "Message1";
  sleep(3);
  this.chat = "Message2";
  setTimer(3);
} 


I'm pretty sure you've been told this before but use 2 equal signs instead of one in an in if statement. I.e. if (this.variable == 1) { // stuff

Oh, Duh. Wow, Can't believe I didn't think of that x.x Thanks=P
And yeah I have, But it works either way:P
Thanks again

[Crow]

Originally Posted by Fysez

But it works either way:P

No, it does not. Just don't do it. Using a single equality sign makes this an assignment. You do not want that.

[Tricxta]

Originally Posted by Crow

No, it does not. Just don't do it. Using a single equality sign makes this an assignment. You do not want that.

True that, especially in proper languages like java where you can do things like while ((aString = br.readLine()) != null){...

It's best to practice proper coding form at all times or you set yourself up with nasty habits which catch up with you later on

[Hezzy002]

lmao quote of the year, "In proper languages like Java..."

[Emera]

Originally Posted by Hezzy002

lmao quote of the year, "In proper languages like Java..."

It's not as bad as me assuming you coded a chat room in VB just because of the icon of the window

[cbk1994]

Originally Posted by Hezzy002

lmao quote of the year, "In proper languages like Java..."

You may not think Java is a good language, but how is it not a proper one? Are all languages you dislike improper?

[Hezzy002]

Originally Posted by cbk1994

You may not think Java is a good language, but how is it not a proper one? Are all languages you dislike improper?

I dunno, define proper. Isn't proper just an opinion? Opinion of the masses isn't too supportive of Java.

[cbk1994]

Originally Posted by Hezzy002

I dunno, define proper. Isn't proper just an opinion? Opinion of the masses isn't too supportive of Java.

Don't know what masses you're polling, Java is still one of the most widely-used programming languages. It certainly has faults, but I wouldn't "lmao" at someone saying that Java is a proper language, especially when they're comparing it to GScript.

[Hezzy002]

Originally Posted by cbk1994

Don't know what masses you're polling, Java is still one of the most widely-used programming languages. It certainly has faults, but I wouldn't "lmao" at someone saying that Java is a proper language, especially when they're comparing it to GScript.

Perl is still widely used, mate. Doesn't mean the reasonable people like it.

EDIT: Not really saying that I have any huge issues with Java. The biggest qualms I have are in regards to the GC (Something I only want to see in an embedded scripting language), lack of operator overloading (Something useful that helps continuity), and the fact that everything requires a wrapper class (Hardcore OO is counter productive to a purely functional program).

Most of my opinions are also heavily based on game development. The language and VM just isn't suited to it IMO. There isn't a lot of middleware for Java, low-level functionality is out the window, and even though the VM executes relatively quick because it's JIT'd, GC is a huge bottleneck. Imagine if CoD had stuttering ingame as the Java VM frantically searched through memory to try to find some available to allocate and others to free (Not multithreaded, pretty sure it's impossible to do completely asynchronously).

Also can't handle an object's memory directly (Super useful for parsing binary file formats; just pointer to file data -> struct in the same format and the header's parsed), can't even shallow copy objects automagically (memcpy would work in C).

Sure, these issues wouldn't crop up for a lot of programming projects, but they cropped up hundreds of times for me when I was trying to make a game engine in Java, and pretty much every game developer I know hates Java and JVM with a passion.

[Crono]

Originally Posted by Hezzy002

lmao quote of the year, "In proper languages like Java..."

ya, we all know erlang is the way to go!

[DustyPorViva]

You may also be interested in making this a bit more flexible using arrays.

PHP Code:

//#CLIENTSIDE
function onCreated() {
  // Create an array with a value for each message desired
  this.messages = {
    "message one!",
    "message two!",
    "message three!",
    "message four!"
  };

  // Initiate the timeout loop
  onTimeout();
}

function onTimeout() {
  // Loop through each item in this.messages array
  // for (var : array) will loop through 'array' and execute the code for each value
  for (temp.i : this.messages) {
    player.chat = temp.i;
    sleep(3);
  }
  // Restart the loop
  setTimer(3);
} 


With such an approach all you'd have to do is add more messages to the array to create a larger loop.