issue concerning default controls

[jake13jake]

Well, I brought this up a long, long time ago.
Classic has long supported the use of whistling with the "W" key.
Since then, hug has been added with the "H" key.
I wish to add "C" for focus toggle and "N" for nickname view toggle.

However, with so many extra key definitions, the likelihood of a conflict with default controls increases. It makes me hesitate to add a keycode for ease of use.

One may suggest overriding all default controls to avoid such a conflict, such as strictly assigning the sword to the "S" key. However, this could really become a conflict to some players. One instance may be that one player may prefer to have the controls be entirely on one side of the keyboard from the result of a nerve disorder or some such handicap.

I would like to request that servers have the ability to add extra key definitions to the default controls when the player is on their server, and that when logging onto a server with extra key definitions, the control set being saved for that specific server.

Most of this I say because I have a friend with cerebral palsy. But hey, he really likes his video games.

[Fox1545]

Originally Posted by jake13jake

Well, I brought this up a long, long time ago.
Classic has long supported the use of whistling with the "W" key.

This is exactly when I stopped playing classic. It is pretty hard to move around when your character starts whistling whenever you try to move upwards.


Just make your entire set of controls configurable.

[jake13jake]

Originally Posted by Fox1545

This is exactly when I stopped playing classic. It is pretty hard to move around when your character starts whistling whenever you try to move upwards.


Just make your entire set of controls configurable.

I feel it would be better for both the user and the server just to have them load onto the default controls. When you make the keyset configurable on the server, it adds confusion. You would of course want to script it to override the default configurations (you can't override the default controls if they're not based on default), and the user would immediately wonder, what is so screwed up about this server? I'm pressing the keys I set in my options but nothings working! Of course, most FAQ are trained in questing and not scripting, so the odds that they are able to help aren't too good.

[The Evil Within]

This is all done with a script using the keydown command. It has nothing to do with your configuration setup. For them to make things like this induced into the configuration it would have to be things put onto every server. Not all servers want the ability to focus wherever you want, nor do all servers want that annoying whistle from classic enabled at all. Delteria put in an NPC that lets you toggle the hide nicks with the N key, but you have the option to delete and re-obtain the NPC whenever you wish. I think if other servers were to induce this it would please people just as well. Have a level in or near onlinestartlocal with an NPC that offers a 'Hot Keys' NPC which will toggle all functions (whistle, hide nicks, focus, etc.) with specific buttons. If the player ever decides that it interfere's with his or her button configuration they can simply open their weapons GUI and delete the NPC.

[Tyhm]

I feel it would be better if all the default controls were shunted into GScript for rescripting instead of hidden somewhere in the hardwired code, but that's me.

[jake13jake]

Originally Posted by The Evil Within

This is all done with a script using the keydown command. It has nothing to do with your configuration setup. For them to make things like this induced into the configuration it would have to be things put onto every server. Not all servers want the ability to focus wherever you want, nor do all servers want that annoying whistle from classic enabled at all. Delteria put in an NPC that lets you toggle the hide nicks with the N key, but you have the option to delete and re-obtain the NPC whenever you wish. I think if other servers were to induce this it would please people just as well. Have a level in or near onlinestartlocal with an NPC that offers a 'Hot Keys' NPC which will toggle all functions (whistle, hide nicks, focus, etc.) with specific buttons. If the player ever decides that it interfere's with his or her button configuration they can simply open their weapons GUI and delete the NPC.

keydown(int) detects a key that was set by the default controls.
keydown2(int,ignorecase) detects a key that is not set by the default controls.
What I'm saying is allow servers to build new default controls, probably in the serverops with an icons list for them at all. That way you don't run into any conflicts.

I seriously doubt keydown2 was meant to create control conflicts to begin with, but I don't want to impose so many controls because i don't want to cause conflicts with the default controls, and the only way to really make it work would be through integration with the client.

Making a hot keys script in the weapons menu for the game really detracts from the environment of the game. Since when would "hot keys" be a weapon in any other game? It just doesn't make sense. It would also make it easier for the servers to be able to integrate with default controls.

Not just the server, but the users would have an easier time. Instead of having to work with two different control menus, they can have one to work with.

The only place that a hot keys script would make sense is if it were to entirely replace the default controls, and this, too, could confuse players.

[Tyhm]

Pretty sure that's what I said. :-P
If GScript2's so powerful, shouldn't there be a command for opening windows?
There is?
So couldn't there be a command for playing with the settings in said window?
Soo why have a F1 Config window at all when you can have a if (keydown(F1 )){ window a="..."; open window a; ...? I'm not saying have every server script it, I'm saying let any server overwrite it.

[jake13jake]

Originally Posted by Tyhm

Pretty sure that's what I said. :-P
If GScript2's so powerful, shouldn't there be a command for opening windows?
There is?
So couldn't there be a command for playing with the settings in said window?
Soo why have a F1 Config window at all when you can have a if (keydown(F1 )){ window a="..."; open window a; ...? I'm not saying have every server script it, I'm saying let any server overwrite it.

Well, in v4 it's a the F3 window. It already has checks for duplicate key configs for different things, and allows you to choose up to two keys, I believe, for every default key. There is no way to check which keys are already in use unless the user presses them. There is no way to inherit the keyset that the user has. All and all, Tyhm, I disagree with you on the idea that we should even overwrite it, I'm saying that we should have the ability to append to it when the user logs in to the specific, and that the appended key configs be saved on a server-by-server basis (so going to a new server you can have a different key config). Apparently Stefan has no current interest in this or he'd have already replied.

[jake13jake]

Maybe I should add a list of keys that I plan on using?

PHP Code:

  this.KEY_SWORD  = 5;
  this.KEY_ACTION = 6;
  this.KEY_ITEM   = 4;

  //extra controls (keydown2() detection)
  this.KEY_WHISTLE = getkeycode("w");
  this.KEY_HUG     = getkeycode("h");
  this.KEY_RATINGS = getkeycode("r");
  this.KEY_NICKS   = getkeycode("n");
  this.KEY_CAMERA  = getkeycode("c");
  this.KEY_FOCUS   = getkeycode("f"); 


Key down functionality is most preferred. I hate chat commands. The best way currently to make changes would be to make it so that you can change the key with "/key whistle w" or something. This should seriously be considered though.

[Tyhm]

Hear hear...yeah, your way is a bit more elegant. Heck, put that in serveroptions, then you can just tack stuff on to the config window. Make the extant boxes in the control window part of a scrolling list, the defaults...
Strike that, no defaults. Or rather, let's see:
Set up serveroptions to use the defaults unless you say otherwise
Allow the server to set which keys are configurable, and what the hey, their default settings.

NPC Code:

---

serveroptions: 

Defaultkeys=FALSE

KEY_UP="8",UPARR

KEY_LEFT="4",LEFTARR

KEY_DOWN="2",DOWNARR

KEY_RIGHT="6",RIGHTARR

KEY_SWORD="S"," "

KEY_ACTION="A",RSHFT

KEY_ITEM="D",RCTL

KEY_WHISTLE="W",

KEY_HUG="H",

KEY_RATINGS="R",

KEY_NICKS="N",

KEY_CAMERA="C",

KEY_FOCUS="F",

---

Then you hit F3 and it says
UP: [8] [↑]
LEFT: [4][←]
...
WHISTLE: [W][ ]
HUG: [H][ ]
RATINGS: [R][ ]
NICKS: [N][ ]
CAMERA: [C][ ]
FOCUS: [F][ ]

All with a scrollbar on the side so you can scroll down as far as you need to...the bad news is it'd take a little bit of doing, the good news is scroll bars are /relatively/ easy to do. Insofar as I've done 'em in class, but I hated it.

It's an idea. It's a pretty idea too. But does Stefan like it enough to sacrifice an afternoon doing it for us?

[jake13jake]

Originally Posted by Tyhm

Hear hear...yeah, your way is a bit more elegant. Heck, put that in serveroptions, then you can just tack stuff on to the config window. Make the extant boxes in the control window part of a scrolling list, the defaults...
WHISTLE: [W][ ]
HUG: [H][ ]
RATINGS: [R][ ]
NICKS: [N][ ]
CAMERA: [C][ ]
FOCUS: [F][ ]

All with a scrollbar on the side so you can scroll down as far as you need to...the bad news is it'd take a little bit of doing, the good news is scroll bars are /relatively/ easy to do. Insofar as I've done 'em in class, but I hated it.

It's an idea. It's a pretty idea too. But does Stefan like it enough to sacrifice an afternoon doing it for us?

I would recommend:

append extra keycodes with preferred starting value
where once the values are saved to a server folder on the client
the preferred starting value no longer applies. On initialization, the preferred starting values of keycodes shouldn't overwrite any of the other values.

appendkeycodes=r,n,f,c,w,h
appendkeycodeicons=server_icoratings.png,server_ic onicks.png,server_icofocus.png,server_icocamera.pn g,server_icowhistle.png,server_icohug.png

right now keydown goes to keydown(10), which is pausing
on the particular server
keydown(11) would detect the ratings key
keydown(12) would detect the nick toggle key
keydown(13) would detect the focus toggle key
keydown(14) would detect the camera mode toggle key
keydown(15) would detect the whistle key
keydown(16) would detect the hugging key

That's all I'd really care for, though some people might go crazy and want to initialize two starting key values (which wouldn't be wise).

[Tyhm]

I say allow for overwriting the defaults. Just because Classic doesn't want to remove the "P IS FOR PAUSE!@!" option doesn't mean another server won't someday.

[jake13jake]

Originally Posted by Tyhm

I say allow for overwriting the defaults. Just because Classic doesn't want to remove the "P IS FOR PAUSE!@!" option doesn't mean another server won't someday.

If you talk about strictly removing it, then I might see where you're going. But for accessibility standards, overriding default controls is just wrong.

[Tyhm]

*shrugs* I guess there's a point there.
Perhaps if you want to remove a feature like pause you'd put in a serveroption
KEY_PAUSE=
so it's not only unmapped but unlisted in config. You can hit P all day, it won't do anything. Hit F3, Pause is grayed out. Then when you want to add one, rather than listing KEY_UP and so forth just list
KEY_WHISTLE="w" to add one or
KEY_PAUSE= to remove one. The defaults would still be there by virtue of nobody said otherwise. The append approach (and perhaps a Disable/Remove approach) could work too - it's been a while since I looked at a serveroptions file so I don't recall the syntax - you'd just have to specify a label string (or is it really pngs now?) to list next to the "W" in the F3 window.