My Script Thread

[Imperialistic]

So as I stated before I'm trying to teach myself further into GS2 and I would appreciate any help or criticism. I guess this is where I'm going to post my 'in progress' scripts and get feedback from you guys whether it's correct or not.

The following script is basically something I am just toying around with to help me sharpen my skills on this particular area (which I'm poor at).

PHP Code:

function onActionServerSide(cmd, target) {
  if (cmd == "info") {
    temp.pl = findPlayerByCommunityName(target);
    temp.level = temp.pl @ " is in the level: " @ temp.pl.level;
    temp.loc = " X: " @ temp.pl.x @ "   Y: " @ temp.pl.y;
    if (pl == null) {
      return player.chat = "(player not found)";
    }
    pl.triggerClient("gui", this.name, "info", player.communityname);
    echo("Info Bot v2 - Level: " @ temp.level);
    echo("Info Bot v2 - X/Y: " @ temp.loc);
    echo("Info Bot v2 - Gralats: " @ temp.pl.gralats);
    echo("Info Bot v2 - ID: " @ temp.pl.id);
  }
}

//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/info ")) {
    temp.tokens = player.chat.tokenize();
    temp.acc = temp.tokens[1];
    player.chat = "Info received!";
    triggerServer("gui", this.name, "info", acc);
  }
} 


Reminder: This isn't finished, it's merely to focus on my weak points and get feedback from more advanced scripters.

I first was coding the echo to look something like this:

PHP Code:

echo("Info Bot v2 - Level: " @ temp.acc @ "is located at: " @ temp.level @ "X: " @ temp.pl.x @ "Y: " @ temp.pl.y) 


But then I realized it was jamming too much into one thing, so I decided to space it out like so:

PHP Code:

    temp.pl = findPlayerByCommunityName(target);
    temp.level = temp.pl @ " is in the level: " @ temp.pl.level;
    temp.loc = " X: " @ temp.pl.x @ "   Y: " @ temp.pl.y;

    echo("Info Bot v2 - Level: " @ temp.level);
    echo("Info Bot v2 - X/Y: " @ temp.loc);