Quote:
Originally Posted by cbk1994
Your styling is inconsistent (use of braces on own lines and indentation of braces). You should use account names internally, not community names. Logs should also contain account names (community names are fine in addition). Keep in mind that community names can change and some players have no community name set.
Instead of using a blank if-statement, just do
PHP Code:
if (! (player.account in this.access)) {
The formatTimeString line doesn't seem to be doing anything.
You should either use SPC or @ with a spaces inside the concatenated strings. Consistency is key.
It looks like it will work, though. Thanks for submitting to the Code Gallery, we need more scripters interested in helping the community. In the future, it would probably be best if you post a thread outside of the Code Gallery first so that you can get feedback. The idea is for this forum to be a repository of high-quality scripts that can either be used or learned from. If you make a thread in the main NPC Scripting forum, there are plenty of scripters who will be happy to give you advice to help you polish it before posting it in the Code Gallery. |
Thank you for the input. I've updated the post with your advice.
As to the community name / account thing, I thought using player.account was inefficient when the community name stuff came out? I could be wrong though, just something I read a while ago.
And on the styling, for me its really just preference, its really easy for me to read/edit this way