Quote:
Originally Posted by gaben
PHP Code:
function onCreated(){
this.i = 0;
}
function onKeyPressed(code, key){
if(key == "[" && this.i >= 0 && this.i < 3){
this.i++; // increment
player.chat = this.i; // print out for verification
}
else if(key == "/" && this.i > 0){ // don't decrement 0 to -1!
this.i--;
player.chat = this.i;
}
}
|
It's unnecessary to initialize a var to be set to 0. When incrementing, checking the condition 'this.i >= 0' is unnecessary. Also, you have the keys swapped.
Astram, I would use the method Crow described. In the end it should look somewhat like this:
PHP Code:
function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode) {
switch (keycode) {
case 219: this.selectedid = (this.selectedid - 1) % this.rights.size(); break;
case 220: this.selectedid = (this.selectedid + 1) % this.rights.size(); break;
default: return;
}
player.chat = this.rights[this.selectedid];
}