Graal Forums - Sleep() drops scope!

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Sleep() drops scope! (https://forums.graalonline.com/forums/showthread.php?t=87354)

Sleep() drops scope!

I know this has been reported before, but I couldn't find it, so I'm going to report it here again. It's definitely something to fix in the NPC-Server.

I have a level NPC that joins to a class, inside of the class I have:

PHP Code:


		
			
function onPlayerEnters() {
  testFunc();
}

function testFunc() {
  for (temp.i=1;temp.i<4;temp.i++){
    sendrpgmessage(temp.i);
    sleep(1);
  }
}

It sends the RPG message to me as:

HTML Code:

1

If I remove the sleep from the for loop, it will return:

HTML Code:

Which is correct.

Now, if I do:

PHP Code:


		
			
function onPlayerEnters() {
  testFunc();
}

function testFunc() {
  for (temp.i=1;temp.i<4;temp.i++){
    findplayer("Tigairius").sendrpgmessage(temp.i);
    sleep(1);
  }
}

It returns:

HTML Code:

No problem! (Thanks Ziro for helping me figure that out.) Sleep is causing the function to lose scope of the player. I spent hours trying to figure this out. :cry: Time I could have spent progressing further in the script!

It definitely needs to be fixed please!!!

this used to piss me off all the time and I could never figure out how to fix it D:

Definitely needs to be fixed. I had a system that, since I had no clue about what I was doing wrong, had to not use a loop, which sucked because only a number was changing.
Also, maybe sleep could not be interrupted (or keep going) when using another function?

The first example seems to work fine for me. I'm using a WNPC. Would that make a difference?

Yea I noticed this a long time ago myself. And I don't remember reporting it either; my attitude towards the lack of updates is probably why.

Quote:

Originally Posted by Tigairius (Post 1513962)

I spent hours trying to figure this out. :cry:

Should've come to me sooner! :p

Quote:

Originally Posted by LoneAngelIbesu (Post 1513984)

The first example seems to work fine for me. I'm using a WNPC. Would that make a difference?

I assume you were doing it on serverside, obviously it would never loose the player scope clientside.

The loss of scope when using sleep has been a problem with the script engine since day one, I am not sure how easy it is to fix if it is some kind of delayed scheduling. Does it also occur while using waitfor?

Quote:

Originally Posted by Skyld (Post 1514016)

Does it also occur while using waitfor?

I'm fairly certain it does not.

You could use scheduleEvent() alternatively, couldn't you?

Quote:

Originally Posted by FreezeBurnX (Post 1514022)

You could use scheduleEvent() alternatively, couldn't you?

Yes, but scheduleevent is inconvenient because it is harder to keep track of loops.

Maybe there's a way to store the reference to the player? I don't know exactly how it is done on graal, but something amongst the lines...

PHP Code:


		
			
function onPlayerEnters(eventPlayer) {

  testFunc(eventPlayer);

}



function testFunc(player) {

  for (temp.i=1;temp.i<4;temp.i++){

    player.sendrpgmessage(temp.i);

    sleep(1);

  }

}

Yes you can also do temp.pl = player and then use temp.pl.
Currently triggered events are keeping care of the player scope (scheduleevent, trigger, etc.) but not functions that suspend the script executing (sleep, waitfor). This has always been like that, but might be good to fix it someday.

I almost find this scary. Sure, there are workarounds, but it's a bit frightening how it loses scope like that.

Quote:

Originally Posted by FreezeBurnX (Post 1514028)

Maybe there's a way to store the reference to the player? I don't know exactly how it is done on graal, but something amongst the lines...

PHP Code:


		
			
function onPlayerEnters(eventPlayer) {

  testFunc(eventPlayer);

}



function testFunc(player) {

  for (temp.i=1;temp.i<4;temp.i++){

    player.sendrpgmessage(temp.i);

    sleep(1);

  }

}

Yes, that's basically what I did, but it can cause a lot of problems for people who aren't aware of this problem.