I need some help with this...
 

I'm having some problems with the following script, i don't see what's wrong, please help me...

// NPC made by Cyrin
setimg beer.png
if (playertouchsme) toweapons Dagger;
if (weaponfired) {
if (strequals(#s(client.equipment),fists)){
setstring client.equipment,dagger;
setplayerprop #c,Equipped Dagger;
setstring client.weaponpower,2;}
if (strequals(#s(client.equipment),dagger)){
setstring client.equipment,fists;
setplayerprop #c,Unequipped Dagger;
setstring client.weaponpower,1;}}

The beer stuff isn't in th original script >.>
And you also need to set a flag "client.equipment=fists".

you don't need those "#s()"s around the string, I don't remember if that'll kill the script or not, but don't use them there

Re: I need some help with this...
 

missing a ;

yes you do :x (last time I checked at least)

That didn't help, it even stopped the script from working :o

Nobody else spotted this?

NPC Code:

---

if (weaponfired) { 

  if (strequals(#s(client.equipment),fists)){ 

    setstring client.equipment,dagger; 

    setplayerprop #c,Equipped Dagger; 

    setstring client.weaponpower,2;

  } 

// Hey, look! client.equipment, at this point, equals dagger!

  if (strequals(#s(client.equipment),dagger)){ 

    // So let's get rid of the dagger and bring the fists back, 

    // despite the fact that we've just got rid of the fists!

    setstring client.equipment,fists; 

    setplayerprop #c,Unequipped Dagger; 

    setstring client.weaponpower,1;

  }

}

---

Use some kind of small modification like this to check whether or not the equipment has already been changed. Oh, and have the default weapon set automatically.

NPC Code:

---

if (weaponfired) {

  this.check=0;

  if (strequals(#s(client.equipment),fists)){

    this.check=1;

    // dagger equip stuff..

  } 

  if (strequals(#s(client.equipment),dagger) && this.check=0){ 

    // fist equip stuff..

  }

  if (strequals(#s(client.equipment),)){

    // default weapon setting stuff..

  }

}

---

OMG, other than the two obvious facts:
(1) You didn't even put if (created). That is like a BIG no-no to put just setimg like that x-x
(2) It's a flat out bish to read, you didnt' really use any formatting! x-x

But other than that, I thought it would be obvious. If you tell it if you are using fists, then it switches to a dagger, but then directly underneath it checks it to switch a dagger to a fist. It changes it to a dagger, but then right back. There is a little thing known as return; that is very helpful x-x
---Shifter

Re: I need some help with this...
 

if (playertouchsme) { toweapons Dagger; }

Re: Re: I need some help with this...
 

You don't need brackets for a single command.

I followed the aid of Growlz and... succeeded! :)

Re: Re: I need some help with this...
 

HOLY CRAP!!
I just realized I have not once had to check my own strings in any script I have ever made!!! Gyayayaya, and to think I've scripted for almost 3 years now!

Re: Re: Re: I need some help with this...
 

maybe its time you did.. doesn't work without the #s

Re: Re: Re: I need some help with this...
 

Er, oh. This is what I get for trying to correct people, when I can barely script myself :(

Re: Re: Re: Re: I need some help with this...
 

It doesn't hurt to have them, & putting brackets around stuff (not sure if this holds true in gscript or not) speeds up processing of the script (barely, but still :P)

Re: Re: Re: Re: Re: Re: I need some help with this...
 

its easier for it to determine what is being typed is (a command/evaluation/etc).. again, i'm not saying it holds true for gscript, because I wouldn't know :P

if (created) variable=5*5;

evaluation?