Graal Forums

Graal Forums (https://forums.graalonline.com/forums/index.php)
-   NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)
-   -   House System (https://forums.graalonline.com/forums/showthread.php?t=134265419)

Gunderak 12-26-2011 10:06 AM

House System
 
1 Attachment(s)
About
This house system allows players to click Enter House and get warped to their own personal house.
Yuu can also click Invite friends to invite players to your house.

How to use it?
Attached is the House System I am currently working on.
To use it add this right to yourself rw levels/houses*.nw then upload the default_house.nw file and the default_house_inside.nw to there, next add rw levels/houses*.nw to the NPC-Servers rights.
Now all you need to do is add the HouseSystem (WEAPON).txt file as a weapon script to your'e server and add the Furniture (CLASS).txt file as a class.
If there are problems with the script or any bugs, please post here.

Future Additions
1. Improvements on the furniture system.


Updated
It now features two levels, an inside and outside level for each player.
It also has a furniture button, which isn't working yet, but I will release an update here when I script it.
It also now has a furniture system, Enter you're house and click Furniture.
To add furniture to youre self add clientr.furniture.chair=chair.png etc etc.
To place furniture left click, to remove it right click.

Credits
1. Gunderak (Gunderak) - The outside level and scripts.
2. TNC (fight4life) - The inside level.

-Enjoy

Emera 12-26-2011 05:27 PM

Can you make a quick list of features? I want to see what it can do. I've never seen a house system before other than Era's so it'll be cool to see what you've done.

Gunderak 12-26-2011 07:27 PM

One it allows you to enter you're house.
Two it allows you to invite other players to you're house.
Three when you exit you get warped right back where you were.

scriptless 12-26-2011 07:46 PM

Quote:

Originally Posted by Gunderak (Post 1679552)
One it allows you to enter you're house.
Two it allows you to invite other players to you're house.
Three when you exit you get warped right back where you were.

Similar to how houses on Kingdoms work too?

callimuc 12-26-2011 08:28 PM

Quote:

Originally Posted by scriptless (Post 1679553)
Similar to how houses on Kingdoms work too?

And the iServers. At least it sounds like that.

scriptless 12-26-2011 08:55 PM

Quote:

Originally Posted by callimuc (Post 1679558)
And the iServers. At least it sounds like that.

I am not familiar with iphone servers. While I do own an iPhone I prefer to play Graal Kingdoms on the pc..

Gunderak 12-27-2011 08:11 AM

Bump :3
-Updated

callimuc 12-27-2011 01:31 PM

Quote:

Originally Posted by Gunderak (Post 1679621)
Bump :3
-Updated

With?

Gunderak 12-27-2011 04:13 PM

Read Updated bit lol

It now features two levels, an inside and outside level for each player.
It also has a furniture button, which isn't working yet, but I will release an update here when I script it.
It also now has a furniture system, Enter you're house and click Furniture.
To add furniture to youre self add clientr.furniture.chair=chair.png etc etc.
To place furniture left click, to remove it right click.

EDIT
You have to also add folder config.
level houses/*.nw

eryal 01-15-2012 06:03 AM

It wont freakin work and its kinda making me mad ;(

Hezzy002 01-15-2012 09:10 AM

I'm really excited for when servers implement Gunderak's scripts, so I can exploit all their security flaws and become a Graal God.

callimuc 01-15-2012 11:53 AM

Quote:

Originally Posted by eryal (Post 1681710)
It wont freakin work and its kinda making me mad ;(

How about if you will take it as template and make yourown one or get someone making your own?
Also you should tell us what exactly is not working. Are the buttons not showing up? Won´t it warp you?
Also what kind of computer you got? MAC? Windows?
And what Graal version are you using?

Gunderak 01-15-2012 04:18 PM

Quote:

Originally Posted by Hezzy002 (Post 1681713)
I'm really excited for when servers implement Gunderak's scripts, so I can exploit all their security flaws and become a Graal God.

Hezzy, I don't think it's a good idea to say these kind of things here.
And how would you exploit them? you probably don't even know the first thing about hacking.

Crow 01-15-2012 06:07 PM

Quote:

Originally Posted by Gunderak (Post 1681726)
And how would you exploit them? you probably don't even know the first thing about hacking.

Considering that he's definitely one of the better coders around, he should know enough to do some nasty things, abusing several flaws with your code/code of others.

fowlplay4 01-15-2012 07:21 PM

Quote:

Originally Posted by Gunderak (Post 1681726)
you probably don't even know the first thing about hacking.

You should probably learn something about script security.

I took a minute to look over your code and found quite a few things he could exploit.

He could generate all the house levels he wanted with a trigger, warp into people's houses and drag in their owner's without permission, place furniture in any level he wanted, use your furniture placer to display naughty images (this can be done without exploiting a script though), destroy people's furniture without permission.

Hezzy002 01-15-2012 08:00 PM

Quote:

Originally Posted by fowlplay4 (Post 1681733)
You should probably learn something about script security.

I took a minute to look over your code and found quite a few things he could exploit.

He could generate all the house levels he wanted with a trigger, warp into people's houses and drag in their owner's without permission, place furniture in any level he wanted, use your furniture placer to display naughty images (this can be done without exploiting a script though), destroy people's furniture without permission.

Ruining my aspirations of Graal Godhood, but whatever.

fowlplay4 01-15-2012 08:04 PM

Quote:

Originally Posted by Hezzy002 (Post 1681739)
Ruining my aspirations of Graal Godhood, but whatever.

I'm sure his server is full of treasures for you to find.

Crow 01-15-2012 08:14 PM

Quote:

Originally Posted by fowlplay4 (Post 1681741)
I'm sure his server is full of treasures for you to find.

Sad thing is: you're probably right.

Tolnaftate2004 01-15-2012 08:56 PM

Quote:

Originally Posted by fowlplay4 (Post 1681733)
He could generate all the house levels he wanted with a trigger, warp into people's houses and drag in their owner's without permission, place furniture in any level he wanted, use your furniture placer to display naughty images (this can be done without exploiting a script though), destroy people's furniture without permission.

All of these things with a single trigger.

fowlplay4 01-15-2012 10:27 PM

Your system is horrid, and there's more problems with it then the obvious security ones but I don't care enough to tell you how to fix everything.

Pretty much all the problems stem from no server-side validation whatsoever.

Problem: He could generate all the house levels he wanted with a trigger.

Solution: Only allow levels to be generated when the player enters the house. If the levels don't exist when player's are invited to them have an error appear instead. Force the player to enter their house before even allowing them to invite people to it.

Problem: Warp into people's houses and drag in their owner's without permission.

Solution: Your invite system needs to be re-designed so there's an actual invite on the server-side the owner has to accept. If people aren't supposed to be in the house when the owner's not there, don't let them warp to it.

Problem: Place furniture in any level he wanted.

Solution: Make sure the player is in his house or has permission to lay furniture in the level. You should also make sure they actually have that piece of furniture as well.

Problem: Use your furniture placer to display naughty images (this can be done without exploiting a script though).

Solution: There's a server option you can use, it's a disable-all allow only a few solution though. Just display the image to client only by using 200 or above instead.

Quote:

Originally Posted by Stefan (Post 1677677)
showimgstypes=all or poly,ani,img,text
showimgsallowedganis=all
showimgsallowedimages=all
showimgsfilterlog=true -> logs to logs/showimgsfilter.txt

Problem: Destroy people's furniture without permission.

Solution: Add a check to confirm the player has permission to destroy the furniture. I.e: If they're the actual owner of the house.

Gunderak 01-16-2012 03:05 AM

Thanks for the informative post, I will try to fix all issues when I am home.

Vlad1 04-28-2012 03:10 AM

one glitch within your house script is if a player is in jail they can enter their house and exit their house and easily get out of jail

fowlplay4 04-28-2012 03:33 AM

Quote:

Originally Posted by Vlad1 (Post 1693193)
one glitch within your house script is if a player is in jail they can enter their house and exit their house and easily get out of jail

That's not really a glitch, more a custom condition that you need to script into it yourself.

A generic check like this could be added to prevent warping:

PHP Code:

temp.lvls serveroptions.jaillevels.tokenize(",");
if (
player.level.name in temp.lvls) {
  
player.chat "You are stuck in jail! red dragons";
  return;



skillmaster19 04-28-2012 03:43 AM

from what ive heard hezzy is a pretty notorious hacker lol.

fowlplay4 04-28-2012 03:49 AM

Quote:

Originally Posted by skillmaster19 (Post 1693200)
from what ive heard hezzy is a pretty notorious hacker lol.

might want to read the date on those posts.

red dragons

Gunderak 04-28-2012 01:55 PM

Bumped much? lol
And bahahaha this is my old script.

Devil_Lord2 04-28-2012 09:54 PM

Quote:

Originally Posted by Gunderak (Post 1693225)
Bumped much? lol
And bahahaha this is my old script.

That doesn't mean you should not improve it...
I honestly hate when people post of a script "To help help the Graal community" then when people give suggestions how to make them better or more efficient they 'brush them to the side' and the script is never actually finished.

In my opinion those type of "helping community posts" should be deleted since they aren't too great. Or put into a template section..

You should go back and fix up your old script so it can be once again considered good. :]
If I were you I'd remake the thread once it is finished and delete this one so it stays on the first page / post.

Crow 04-28-2012 10:13 PM

Quote:

Originally Posted by Devil_Lord2 (Post 1693254)
That doesn't mean you should not improve it...

This is not the code gallery. We can let this rot away.

Gunderak 04-29-2012 03:16 AM

David, I have fixed it up and added new features.
But it's in use on Corinthia and I will not be releasing it.


All times are GMT +2. The time now is 04:50 PM.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2026, vBulletin Solutions Inc.
Copyright (C) 1998-2019 Toonslab All Rights Reserved.