![]() |
Item Creation Script
This is a little script ive been working on, not much... Also, not completed yet so expect updates but this system allows you to create weapons to fight with people! It works with melee atm.
But you will have to script the hurting etc. Here ya go Weapon Creation Code: PHP Code:
PHP Code:
PHP Code:
O, Say /items to open the generator =D! |
good job
|
I canīt test it but:
PHP Code:
Quote:
|
screens?
|
Please, if you release on Code Gallery, finish the script ATLEAST
but yea I like it, keep on working :) |
cool stuff @ Astram- you're getting better :)
Quote:
|
Your code styling is inconsistent and looks terrible. Please do the following:
Quote:
setTimer(.005, 1); - setTimer(float): The minimum value is 0.05, and it's only one parameter. Use this.scheduleevent() if you need to pass parameters to the looping event. PHP Code:
PHP Code:
Quote:
The code gallery shouldn't become a repository of poorly written broken scripts. Code reviews can take place outside the forums without issue but to me this sub-forum should be for proper working scripts which developers can take, use, and learn from without issue. |
Quote:
The Code Gallery should be reserved for high-quality scripts. There is a forum where he can post scripts that are incomplete to get feedback on. My reply to another of Astram's code gallery threads: Quote:
Once again, Astram, thanks for trying to help. I'm glad that new scripters have an interest in improving the learning resources available for GScript. This script shows that you are making good progress toward learning GScript. However, posting scripts like this one in the Code Gallery does more damage than it does good. I've recommended this before and I'll recommend it again. Post your scripts in the scripting forum first so an experienced scripter can help you polish it, then post the final version in the Code Gallery. |
Quote:
Do I really have to post "Okay, looks like you're getting a little better but..." before everything for it not be to considered negative and unhelpful? |
Quote:
|
In my opinion, code that is posted in the code gallery should either
Your code is neither because you don't provide any explanation of what's going on (a comment here and there wouldn't hurt!), it's terribly styled, and it's incomplete. Like Chris said, I appreciate that you're trying to help, but unless your goal was to show us what not to do, then this does not belong in the code gallery. |
Quote:
|
Quote:
|
I will take your suggestions and critisizism as I post my next script.
And @ Fowlplayer4 setTimer(.005); works and the 1 was this little test. Would be nice if it let me edit my own post. Though it doesnt for some reason... |
Quote:
|
All times are GMT +2. The time now is 12:52 AM. |
Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2025, vBulletin Solutions Inc.
Copyright (C) 1998-2019 Toonslab All Rights Reserved.