Adding weapons
 

How would i add a weapon though npc sever? i have no clue i forget i think is it addweapon weapon name or something like that

What do you mean?

Creating a weapon in NC or adding a weapon to a player?

adding a weapon to player by using the npc sever message

adweapon weaponname;

You might want to make a player class, and put this in. (GS2 Required.)

Don't confuse the poor kid.

can i add a weapon to the player though a lvl npc like buying items how would i do that the same way?

Add the script to WEAPONS through NPC Control. Then open a level and put a script such as this in it:

//#CLIENTSIDE
if (playertouchsme){addweapon weaponnamehere';}

You'll have to get to known the scripting commands better if you want it to go to your attributes when you say something like 'buy 'weaponname'. Also i don't think it's a good idea to use Clientside anyways.

If you want an NPC to be added to everyones attributes once they logon put this in Control-NPC:

if (actionplayeronline){addweapon 'weaponnamehere';}

addweapon does not work clientside.

NPC Code:

---

// npc called "-weaponadder"



if (actionserverside) {

  if (strequals(#p(0),addw)) {

    with(getplayer(#p(1))) addweapon #p(2);

  }

}



//#CLIENTSIDE

if (weaponfired) {

  triggeraction 0,0,serverside,-weaponadder,addw,#a,NPC/Thinger;

}

---

that npc, when fired, adds the weapon NPC/Thinger to the player.


a level npc (shop or suchlike) could also use that trigger, granted the player has a weapon on them like that one that accepts the addw trigger

addweapon does not work clientside. Please do not give bad advice.

If people were meant to be able to be able to add any weapon clientside, it would not be a serverside command. Please do not encourage the circumvention of this security measure.

How else do you propose you make a shop that adds weapons, or a droppable inventory system?
A DB? That would confuse the poor person.
And besides, the only people that would know how to use the trigger would be staff. Players uploading a playerhouse with a script to add weapons wouldn't know how, plus, any player levels should be inspected and approved before uploading in the first place.
Nearly every server has a system npc with an addweapon function on it, so don't even go there.

Through a nifty serverside level NPC or DB NPC? Also: any decent inventory system would make sure the person should have something before adding it.

Moreso than a triggeraction? Take a moment and think about that.

Or clever trainer users. We don't need what happens on UN to happen on any other server.

Irrelevant. We're talking about the security of a weapon NPC. One would not need to have any other scripts uploaded to exploit the security flaw in that weapon.

And nearly every server had an insecure Control-NPC triggeraction 'actionserverwarp' before we swept the servers and insisted they remove it. A lot of people doing a bad practice does not change the fact that it's a bad practice and insecure.

Calani got own't!

The person you're talking to, however, most likely lacks the intelligence to understand the difference between 'secure' and 'insecure' triggeractions.

And every single server has insecure triggeractions like this, which are actively abused to do things such as reseting people, but the PWA could really care less about their existance.

If i knew it was 'bad' i would'nt have given it. As i stated before, i'm not great when it comes to scripting. My mistake though, i guess.

If I made a 'secure' example or doing it serverside, it would likely confuse the poor person.
Also, I chose a triggeraction becasue it is much easier to understand for a new scripter than a DB.

If you expect a new scripter to be able to create perfectly (or even remotely) secure scripts, there's a problem there.

(With help given like this?) Help given in a form they can understand it, yes. Possibly not secure but that's something that is too complicated for most newer scripters to grasp.


Anyways, I rather think that the question that this entire debate was started over has been answered at least three times already.

So instead you chose to spread an insecure script as an example of something people should do? How does this help, again?

Feel like justifying that claim?

I don't. I did, however, expect you to be able to.

"Here's some (insecure) code. It adds a weapon." is not help. It's a violation of rules 2) and 4) of this forum.

I think it is quite obvious that what Calani provided was simply an example of using the triggeraction and addweapon commands in conjunction; a skeleton script, if you will. As long as the author of the thread understands this, no harm can come of it. Besides, are you suggesting she post a fully functional, fully secure script for him/her? Now that would be breaking the rules.
Just about every programming guide there is starts you out with writing "Hello world" to the screen. The guide doesn't explain complex concepts like security, addresses, or ways that people hack your program until much later (if at all). Security and scripting are two different things. Learning scripting first is essential to understanding security. The author didn't ask for a secure script, just an example of weapons being added.

Sweet, the peanut gallery is here for the party. Let's dance!

It was insecure code without an explanation. See also: the part where I already explained this!

Do you honestly suppose that without the resultant discussion, the author would have understood this? Calani didn't bother saying anything about it until I commented, after all.

Certainly not. If you bothered to pay attention, you'd have noticed I already noted that by posting all that code with no explanation that she was violating rule 2 as it is. If she's going to post some copy&paste code, she should at least make it secure. Otherwise, she's just doing more harm than good.

1) This is not a programming guide.
2) There is no "Hello world" involved.

Since we are now 0/2 in the "talking about related things" department, I must ask: relevance?

1) This is still not a programming guide.
2) Calani still didn't explain any concepts (simple or 'complex').

You do realize that to have a good analogy, you need to compare related things, right?

Learning about script security is an integral part of learning how to script. If you cannot script something securely, you cannot script well.

I believe you need to recheck your facts.

• The author asked for the how, not for an example, and certainly not for the posting of a full script and violation of the forum rules.
• The author asked for a weapon being added by a level npc. Calani supplied an (insecure) weapon triggeraction (and no way to connect it with a level NPC, even if she was interested in answering the author's question).

hmmm

If I asked for help on how to use a command, I wouldn't want it nested in a load of "secure" coding. I would simply want an example and, if need be, apply my own security measures. There's no inherent reason in posting a command example with security included. It provides the answer plus a cumbersome read.

Well, I noticed right away that there were no security features in the script. The first thing I thought was: "Wow, I wouldn't copy and paste that code. It doesn't even check to see who uses it.". I don't even write in GScript. Also, if you say something is insecure, it wouldn't hurt to point out why it is insecure.

It's not copy&paste code. It's an example. If the author copy and pastes it, it's his or her fault for doing so. People who ask for help are supposed to use the help in order to write their own scripts, not to copy and paste the suggestions.
Also, to post what the script does is redundant. The author presumably knows his or her own desires.


1) That's where you're wrong. The NPC scripting forum frequently acts as a scripting guide. In fact, a guide is precisely what this forum appears to function as.
2) So? It was an example, not a direct reference to the current discussion.



Is it necessary to explain commands? If someone gave me something I didn't understand, I would go look up the command. It encourages the self-teaching method, rather than the "oh I got something wrong, can you tell me what to do to the letter?" method.



You also can't script well if you don't grasp elements of the language. The nature of the question the author poses suggests that he or she does not yet have a grasp on some of the commands.
P.S: Why don't you address the author with suggestions on security, rather than engaging in a confrontation with another forumer who was trying to be helpful?
P.P.S: And no, I'm not being hypocritical. I'm simply asking why a moderator who is so concerned with security would be so eager to attack someone's efforts without providing an example of an improved script.


Learning by example is probably the most effective way to learn anything. Including scripting.

1) You did not explain what a trigger was (to someone who does not understand it).
2) You did not note which code would be required to connect the two.

Therefore, you did not connect it.

Very well, as thou dost wish, I shall henceforth comment every line of code that I do post on this most wonderful of forums. *bows low*

You must bow lower to be accepted by Lance. You have to have a negative z value before you get low enough.

This isn't about what you would ask or what you would want. This is about what was asked, what was provided, and why it was the wrong answer.

Now might be a good time to point out that you are not the author of this thread. The discussion point you are attempting to reply to deals not with you but with the author of this thread. You have not answered my question.

Actually, I did. In my first reply to her post. Please read it! :)

Read the forum rules lately? Code that you can copy and paste and use it as-is (or with trivial modifications) on your server is just that.

Yeah, supposed to. In the real world it doesn't quite happen just like that. That's why the rule exists.

Oh, please. His or her own desires are not necessarily equivalent to random code posted by random people in response.

Looks like you need to re-read rule 1 of this forum.

No relation -> false analogy.

If you have sufficient belief that the person you are helping does not understand a command or concept, it behooves you to explain it. That certainly does not mean that you should do all of their work for them, but at least you can give them the information they would need to learn from it (while avoiding giving them the chance to simply copy&paste without learning).

How does this respond to my point that scripting and security are not actually two different things? Your claim that they were separate was what I was responding to, after all.

I consider "Their question did not deal with security, but one of the responses was quite insecure" to be good enough reason for that.

An improved script of which, now? If you're referring to calani's, the approach is flawed. There is no 'improved script' for that approach for this problem.

Different people learn differently, man. The best thing any of us can do is provide people with enough information so they, with every learning style ("give me the the finished code and I will learn" naturally excepted), can learn.