Graal Forums - JKL's Scripting Questions

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - JKL's Scripting Questions (https://forums.graalonline.com/forums/showthread.php?t=134258195)

JKL's Scripting Questions

First I was wondering how do I make this so you grab it and then the box pops up? Right now when i put this in an NPC thing on offline editor and upload it, right after i upload it the box pops up and I click cancel and it doesn't come back.

PHP Code:


		
			
//#CLIENTSIDE

function onCreated()

{

  openURL("http://wiki.graal.net");

}

Change onCreated() to onActionGrab()

Quote:

Originally Posted by Mark Sir Link (Post 1559331)

Change onCreated() to onActionGrab()

I Put this and used an image of my staff block for a test and it didn't work.

PHP Code:


		
			
//#CLIENTSIDE

function onActionGrab()

{

openURL("http://wiki.graal.net");

}

onActionGrab isn't a global function. You'll have to use a triggeraction to make that function. Use the search feature on the forums. ^^

Quote:

Originally Posted by xAndrewx (Post 1559333)

onActionGrab isn't a global function. You'll have to use a triggeraction to make that function. Use the search feature on the forums. ^^

Would you be so kind to search it for me and then come back here and paste it in? :o

I do more of simple scripting such as like in a jukebox/music player I can copy the same thing over and over and insert the url's. Or something like a staff block script which i can change the images or whatever. I more so edit scripts rather than create them entirely. :(

Quote:

Originally Posted by xAndrewx (Post 1559336)

http://forums.graalonline.com/forums...ad.php?t=68333

Thank you, but I could NOT figure that out. Too many different posts, and after they figured it out they didn't even post the new script.

So can someone please help :\

It's in that thread- look again and read what they're saying. We're not supposed to give you the full code...

Quote:

Originally Posted by xAndrewx (Post 1559340)

It's in that thread- look again and read what they're saying. We're not supposed to give you the full code...

>.< I just need one little piece to finish this script !pissed!

I tried this and it didn't work:

PHP Code:


		
			
//#CLIENTSIDE

function onKeyPressed(code, key)

{

switch(key)

{

case "a":

temp.gx = player.x + 1.5 + vecx(player.dir) * 2;

temp.gy = player.y + 2 + vecy(player.dir )* 2;

triggeraction(temp.gx, temp.gy, "Grab";

break;

}

}

openURL("http://wiki.graal.net");

}

triggeraction(temp.gx, temp.gy, "Grab", "");

Add that to a weapon (what you've just posted above) & then add it to a player, you'll then be able to use the function

HTML Code:

function onActionGrab() {

}

Good job ^^

you could always try to use onPlayerTouchsMe()
although i always find it annoying that whenever i hit a sign, i suddenly get this lousy say2 message.

but it would immensly simplify some things

PHP Code:


		
			
//CLIENTSIDE

function onPlayerTouchsMe()

{

  openURL("http://wiki.graal.net"); 

}

I've got a problem with a script, It's in the code gallery, I do not take ownership of it. I want to make it so that I can replace the image it comes with, with an image of my own. But there isn't anything here that says like "IMG=" or anything of that sort. So I was wondering if someone could help me figure this out. :)

PHP Code:


		
			
function onActionServerSide() 

{ 

  if (params[0] == "playerweaps") { 

    for (i = 0; i < player.weapons.size(); i ++) temp.imgs.add(findWeaponNPC(player.weapons[i]).image); 

    triggerClient("gui", name, "openinv", player.weapons, temp.imgs); 

  } 

} 



//#CLIENTSIDE 

function onCreated() 

{ 

  enablefeatures(allfeatures - 4); 

  this.gName = "Inventory_"; 

  (this.gName @ "Window0").destroy(); 

  setTimer(.05); 

} 



function onTimeOut() 

{ 

  this.plWeapon = player.weapon.name; 

  showText(200, 6, 100, "System", "b", "Selected Weapon:" SPC this.plWeapon SPC "[" @ selectedweapon @ "]"); 

  changeImgVis(200, 4); 

   

  setTimer(.05); 

} 



function onKeyPressed(keynr, keyname) 

{ 

  if (keyname == "q") { 

    if ((this.gName @ "Window0").visible == false) triggerServer("gui", name, "playerweaps"); 

    else (this.gName @ "Window0").destroy(); 

  } 

} 



function onActionClientSide("",weaps,imgs) 

{ 

  if (params[0] == "openinv") OpenInventory(weaps, imgs); 

} 



function OpenInventory(invWeapons, invImages) 

{ 

  if ((this.gName @ "Window0").visible == false) { 

    new GuiWindowCtrl(this.gName @ "Window0") { 

      width = 196, height = 177; 

      x = screenwidth/2 - width/2, y = screenheight/2 - height/2; 

     

      canMinimize = false; 

      canMaximize = false; 

      canResize = false; 

      canMove = false; 

      destroyOnHide = true; 

       

      xmod = NULL; 

      ymod = NULL; 

      rowcount = NULL; 

       

      invItems = NULL; 

      // Removes old buttons 

      for (i = 0; i < invItems.size(); i ++) (this.gName @ "Button" @ i).destroy(); 

     

      // Checks for items to display in inventory 

      for (i = 0; i < invWeapons.size(); i ++) { 

        if (!invWeapons[i].starts("-")) invItems.add({invWeapons[i], invImages[i]}); 

      } 

       

      // Displays the items 

      new GuiScrollCtrl(this.gName @ "Scroll0") { 

        width = 187, height = 150; 

        x = 5, y = 23; 

         

        hScrollBar = "alwaysOff"; 

        vScrollBar = "dynamic"; 

       

        for (i = 0; i < invItems.size(); i ++) { 

          temp.var = i / 5; 

          if (temp.var.length() == 1 && i > 0) { 

            xmod = NULL; 

            ymod += 36; 

            rowcount ++; 

          } 

         

          new GuiBitmapButtonCtrl(this.gName @ "Button" @ i) { 

            width = 32, height = 32; 

            x = 5 + xmod, y = 5 + ymod; 

           

            this.itemname = invItems[i][0]; 

            this.itemimage = invItems[i][1]; 

           

            normalbitmap = this.itemimage; 

            mouseoverbitmap = this.itemimage; 

            pressedbitmap = this.itemimage; 

           

            thiso.catchevent(this, "onMouseDown", "onSlotPressed"); 

            thiso.catchevent(this, "onMouseEnter", "onMouseOverSlot"); 

            thiso.catchevent(this, "onMouseLeave", "onMouseExitSlot"); 

          } 

          xmod += 32 + 4; 

        } 

      } 

    } 

    (this.gName @ "Window0").makefirstresponder("false"); 

  } else (this.gName @ "Window0").destroy(); 

} 



function onSlotPressed(obj, keymodifier, mousescreenx, mousescreeny, clickcount) 

{ 

  if (clickcount == 2) { 

    player.chat = "Selected Weapon:" SPC obj.itemname; 

    selectedweapon = player.weapons.index(findWeapon(obj.itemname)); 

    (this.gName @ "Window0").destroy(); 

  } else if (clickcount == 1) (this.gName @ "Window0").text = obj.itemname; 

} 



function onMouseOverSlot(obj) (this.gName @ "Window0").text = obj.itemname; 

function onMouseExitSlot(obj) (this.gName @ "Window0").text = "";

HTML Code:

    new GuiWindowCtrl(this.gName @ "Window0") {  

      useownprofile = true; 

      profile.bitmap = "your image here";

Where exactly does that go? Would you mind copying the script and placing it in there and posting it for me?

Quote:

Originally Posted by jkldogg (Post 1560718)

Where exactly does that go? Would you mind copying the script and placing it in there and posting it for me?

Look in your script for

HTML Code:

new GuiWindowCtrl(this.gName @ "Window0") {

and put it in there

I figured it out, with the help of a nice guy named PowerPronL :)

PHP Code:


		
			
//#CLIENTSIDE

function onCreated() {

  message Grab Me!;

}

function onActionGrab() {

  openUrl("http://www.google.com");

}

You're mixing GS1 and GS2 there.

message Grab me!; in GS2 is basically

this.chat = "Grab me!"; OR

message("Grab me!");

Quote:

Originally Posted by fowlplay4 (Post 1562096)

You're mixing GS1 and GS2 there.

message Grab me!; in GS2 is basically

this.chat = "Grab me!"; OR

message("Grab me!");

Why does that matter? Yeah, it says error, but it seems to work fine. You grab it and the link opens and the message is always on top of the image.

Jukebox (Chris Vimes)

SORRY FOR DOUBLE POSTING (this is my one thread for all my questions)

Having a little problem with this jukebox Chris Vimes made a while back. I personally love this script. I like to be able to listen to music in game rather than having Graal and Internet open. So that there's slightly less lag. ^^

Anyways, the probably is when you start to play a song, if someone shoots a gun the song goes off. Help is appreciated, thanks in advance.

Here's the code

PHP Code:


		
			
////NO ONE TOUCH THIS, ask jkldogg to add songs

//#CLIENTSIDE

function onCreated() 

{ 

  showJukebox(); 

} 

function onKeyPressed( code, key ) 

{ 

  if ( key == "r" ) 

  { 

    setTimer( 0.05 ); 

    Jukebox_Window.visible = Jukebox_Window.visible - 1; 

    GraalControl.makeFirstResponder( true ); 

  } 

} 

function onWeaponFired() 

{ 

  say2( "Press 'r' to toggle jukebox!" ); 

} 

function showJukebox() 

{ 

  playing = this.playing; 

  Jukebox_Window.destroy(); 

  new GuiWindowCtrl( "Jukebox_Window" ) 

  { 

    profile = "GuiBlueWindowProfile"; 

    width = 280; 

    height = 120; 

    x = screenwidth - width; 

    y = screenheight - height; 

    canClose = canMinimize = true; 

    canMaximize = canResize = false; 

    visible = false; 

    text = "Jukebox -"SPC servername; 

    useownprofile = true; 

    profile.transparency = .9; 

    new GuiMLTextCtrl( "Jukebox_Text" ) 

    { 

      profile = "GuiBlueTextProfile"; 

      x = 10; 

      y = 30; 

      width = 270; 

      height = 20; 

      useownprofile = true; 

      profile.align = "center"; 

      text = "<center>Now playing:" SPC playing; 

    } 

    new GuiPopUpMenuCtrl( "Jukebox_List" ) 

    { 

      profile = "GuiBluePopUpMenuProfile"; 

      width = 260; 

      height = 20; 

      x = 10; 

      y = 50; 

      textprofile = "GuiBlueTextListProfile"; 

      scrollprofile = "GuiBlueScrollProfile"; 

      clearRows(); 

      temp.music = { 

      { "Young Jeezy - My President Is Black", "http://dump.ninjapirat.org/files/18%20My%20President.mp3" },

      { "Eminem - Stay Wide Awake", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fbetruger.wrzuta.pl%2Fsr%2Ff%2F4dEUI3jrj34%2Feminem_-_stay_wide_awake.mp3&n=3" }, 

      { "Lil Wayne & Gucci Mane - We Be Steady Mobbin ", "http://yoraps.com/music/lil_wayne-mobbin.mp3" }, 

      { "Gucci Mane - Lemonade", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fwww.djbobbytrends.com%2Fblog%2Fwp-content%2Fuploads%2F2009%2F11%2F03-Lemonade.mp3&n=2" }, 

      { "Iyaz - Replay", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fdoris9403.wrzuta.pl%2Fsr%2Ff%2F1IdqekCNy32%2Fiyaz_-_replay.mp3&n=10" }, 

      { "Eminem - The Way I Am ", "http://cd04.static.jango.com/music/03/40/87/0340874277.mp3" }, 

      { "Eminem - When I'm Gone ", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fwww.myotherdrive.com%2Ffile%2F850.472605.02022008.03344.0067fi%2FEminem%2520-%2520When%2520Im%2520Gone%2520(dirty).mp3&n=5" },

      { "Eminem - Must Be The Ganja", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fkrwawy80.wrzuta.pl%2Fsr%2Ff%2F3QdmGxuaqDV%2Feminem_-_must_be_the_ganja_produced_by_dr._dre_and_mark_batson.mp3&n=7" },

      { "Eminem - Medicine Ball ", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fkrwawy80.wrzuta.pl%2Fsr%2Ff%2F20r1DvaoDFV%2Feminem_-_medicine_ball_produced_by_dr._dre_and_mark_batson.mp3&n=1" },

      { "Gucci Mane - Stupid Wild", "http://www.downloads.nl/cgi-bin/mp3get.cgi?u=http%3A%2F%2Fwww.hilkoo.com%2Fwp-content%2Fuploads%2F2009%2F11%2FGucci-Mane-Ft-Lil-Wayne-Camron-Stupid-Wild-www.hilkoo.com.mp3&n=4" },

      { "Gucci Mane & Usher - Spotlight", "http://c.wrzuta.pl/wa3958/5522c5c9001f5ff94ae34d6e/0/gucci%20mane%20ft.%20usher%20-%20spotlight.mp3?523.187163341582" },

      { "insane", "http://www.mp3-center.org/download_mp3/Eminem/Insane/8109489" },

      { "song", "http://www.yoraps.com/audios1.php?subaction=showfull&id=1267696186&archive=&start_from=&ucat=13&" },

      { "song", "http://www.jamglue.com/tracks/9611377/popout" },

      { "Rihanna - Hard (Featuring Young Jeezy)", "http://c.wrzuta.pl/wa3247/227e7f5b00031adb4b0ea70a/0/rihanna%20-%20hard%20%28featuring%20jeezy%29.mp3?743.254980545283" },

      { "Plies (Featuring Neyo) - Bust It Baby Remix", "http://c.wrzuta.pl/wa793/13199862002be4fc484b789c/0/plies%20ft%20neyo-bust%20it%20baby%20remix.mp3?996.453801590508" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "song", "url!" },

      { "Eminem - Stan", "http://images.mmosite.com/bbs/upload/temp/Stan.mp3" }};       

      for ( temp.i = 0; temp.i < temp.music.size(); temp.i ++ ) 

      { 

        with( addRow( 0, temp.music[temp.i][0] ) ) 

        { 

          this.var = temp.music[temp.i][1]; 

        } 

      } 

      setSelectedRow( 0 ); 

      sort(); 

    } 

    new GuiButtonCtrl( "Jukebox_Stop" ) 

    { 

      profile = "GuiBlueButtonProfile"; 

      width = 75; 

      height = 30; 

      x = Jukebox_Window.width / 2 - ( width / 2 ); 

      y = Jukebox_Window.height - 40; 

      text = "Stop Music"; 

    } 

  } 

  stopmidi(); 

  this.playing = "[None]"; 

  Jukebox_Text = "Now playing: [None]"; 

} 

function onTimeOut() 

{ 

  this.time += .05;; 

  setTimer( 0.05 ); 

} 

function Jukebox_Stop.onAction() 

{ 

  stopmidi(); 

  this.playing = "[None]"; 

  Jukebox_Text = "Now playing: [None]"; 

} 

function Jukebox_List.onSelect() 

{ 

  if ( this.time > 0 ) 

  { 

  this.playing = params[1]; 

  Jukebox_Text.text = "Now playing:" SPC params[1]; 

  play( Jukebox_List.rows[params[2]].var ); 

  } 

} 

function onPlay( title, song ) 

{ 

  this.playing = title; 

  Jukebox_Text.text = "Now playing:" SPC title; 

  play( song ); 

}

Quote:

Originally Posted by jkldogg (Post 1562101)

when guns are fired, do they call the play() function rather than making the sound through a GANI?

Quote:

Originally Posted by Mark Sir Link (Post 1562102)

when guns are fired, do they call the play() function rather than making the sound through a GANI?

My gun sounds are in the actual fire gani, i put the little yellow sound icon thingy :confused:

Go top Options (F1) > Audio > Turn them all down other than radio?

Quote:

Originally Posted by xAndrewx (Post 1562108)

Go top Options (F1) > Audio > Turn them all down other than radio?

Same effect, except I couldn't hear the bullet lol...

Any other ideas? This is making me mad !pissed!

ois- Era has them built in to ganis (last time I worked there...), if you open the gani and look right near the bottom you'll see a

HTML Code:

ANI

[WEIRD STUFF HERE]

PLAYSOUND sound.wav

[WEIRD STUFF HERE]

Try deleting that line? =o (PLAYSOUND)

An alternative would be to find an empty sound file and to replace the Era effects... :[

Quote:

Originally Posted by xAndrewx (Post 1562112)

ois- Era has them built in to ganis (last time I worked there...), if you open the gani and look right near the bottom you'll see a

HTML Code:

ANI

[WEIRD STUFF HERE]

PLAYSOUND sound.wav

[WEIRD STUFF HERE]

Try deleting that line? =o (PLAYSOUND)

An alternative would be to find an empty sound file and to replace the Era effects... :[

hmmm hold on

EDIT: I don't know what you're talking about.

See Attachment

Mixing GS1 and GS2 is just another sign you have no interest in learning how to actually script. The only acceptable case for me personally is the character npcs created by the level editor but everything else is just a no-no.

Also, you have to open the Gani in a text editor.

Quote:

Originally Posted by fowlplay4 (Post 1562128)

What do you mean? I didn't make this script, chris did,; and he realeased it to the Code Gallery. I do want to learn scripting but, I don't have the patience for it.

How do I make the gun not turn off the song?

The jukebox isn't the problem, the problem is with your GANIs (or other sounds on the server).

Quote:

Originally Posted by jkldogg (Post 1562099)

Why does that matter? Yeah, it says error, but it seems to work fine. You grab it and the link opens and the message is always on top of the image.

If you really want to become a scripter, you can't settle for what works. You have to go the extra mile and make it correct.

Quote:

Originally Posted by cbk1994 (Post 1562136)

The jukebox isn't the problem, the problem is with your GANIs (or other sounds on the server).

If you really want to become a scripter, you can't settle for what works. You have to go the extra mile and make it correct.

Okay, will you explain to me how to fix it? Or just come on the server and do it? Please and thank you.

Quote:

Originally Posted by jkldogg (Post 1562143)

Okay, will you explain to me how to fix it? Or just come on the server and do it? Please and thank you.

Andrew already suggested a way to fix it, check the ganis for your bullets and make sure you aren't using play to play the gun sound in your gun scripts.

Quote:

Originally Posted by fowlplay4 (Post 1562149)

Andrew already suggested a way to fix it, check the ganis for your bullets and make sure you aren't using play to play the gun sound in your gun scripts.

Did you see my other post?!!? I showed the attachment and I don't know what the play sound is?

Quote:

Originally Posted by jkldogg (Post 1562154)

Did you see my other post?!!? I showed the attachment and I don't know what the play sound is?

And I said to open the suspected gani that's causing the problem with a text editor like notepad.

Quote:

Originally Posted by fowlplay4 (Post 1562155)

And I said to open the suspected gani that's causing the problem with a text editor like notepad.

Ah, okay.

This is what It said

HTML Code:

PLAYSOUND sound.wav 0.9375 -17.0625

PLAYSOUND sound.wav 0.75 17.375

What now?

---------

Quote:

Originally Posted by fowlplay4 (Post 1562096)

You're mixing GS1 and GS2 there.

message Grab me!; in GS2 is basically

this.chat = "Grab me!"; OR

message("Grab me!");

PHP Code:


		
			
//#CLIENTSIDE

function onCreated() {

  message("Grab me!");

}

function onActionGrab() {

  openUrl("http://forums.graalonline.com/forums/showthread.php?t=134258011");

}

I tried your idea of the replace message thing but, i get errors. Although the script still works fine.. Scripting is confusing, how can you have an error and it works? But at the same time it's still the wrong type of script?
:confused:

PHP Code:


		
			
Error: Missing brackets end: )

Quote:

Originally Posted by jkldogg (Post 1562158)

PHP Code:


		
			
Error: Missing brackets end: )

GS2 doesn't work offline. If you put the script in an actual script editor it won't give any errors.

Quote:

Originally Posted by cbk1994 (Post 1562226)

GS2 doesn't work offline. If you put the script in an actual script editor it won't give any errors.

How do I fix the jukebox so the guns don't turn off the song?

Quote:

Originally Posted by jkldogg (Post 1562252)

How do I fix the jukebox so the guns don't turn off the song?

Everyone else has already given you the answer; fix your GANIs, there's nothing wrong with the script.

Quote:

Originally Posted by cbk1994 (Post 1562256)

Everyone else has already given you the answer; fix your GANIs, there's nothing wrong with the script.

Okay, would you please tell me EXACTLY what to do?

Please re-read the thread.

Quote:

Originally Posted by xAndrewx (Post 1562452)

Please re-read the thread.

Playing a gani with sound in it doesn't stop the jukebox, and neither does it stop if you do play("foo.wav"). I suppose there could be a gun sound played from URL somewhere.

jkldogg, you should probably just find someone to scan your scripts for you.