Graal Forums - Array help

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Array help (https://forums.graalonline.com/forums/showthread.php?t=134264405)

Quote:

Originally Posted by 0PiX0 (Post 1666156)

It's unnecessary to initialize a var to be set to 0. When incrementing, checking the condition 'this.i >= 0' is unnecessary. Also, you have the keys swapped.

Astram, I would use the method Crow described. In the end it should look somewhat like this:

PHP Code:


		
			
function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode) {

  switch (keycode) {

    case 219:  this.selectedid = (this.selectedid - 1) % this.rights.size();  break;

    case 220:  this.selectedid = (this.selectedid + 1) % this.rights.size();  break;

    default:   return;

  }

  player.chat = this.rights[this.selectedid];

}

That returns as a NULL value, you know?

please stop using thiso throughout this script, you clearly have no idea what its intent and purpose is for. I am sure you are having all sorts of scoping issues by calling it since thiso probably refers to a null object or the player itself when you are doing that.

PHP Code:


		
			
//#CLIENTSIDE
function onCreated(){
  this.rights = {"Drag", "Boots", "Blocks"};
  this.selected = 0;
}

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode){
  switch(keycode){
    case 219: this.selected = (this.selected - 1 < 0 ? 0 : this.selected-1); break;
    case 220: this.selected = (this.selected + 1 >= this.rights.size() ? this.rights.size() -1 : this.selected+1); break;
    default: return;
  }
  player.chat = this.rights[this.selected];
}

PHP Code:


		
			
//#CLIENTSIDE
function onCreated(){
  this.rights = {"Drag", "Boots", "Blocks"};
  this.selected = 0;
}

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode){
  switch(keycode){
    case 219: this.selected = (this.selected - 1) % this.rights.size(); break;
    case 220: this.selected = (this.selected + 1) % this.rights.size(); break;
    default: return;
  }
  player.chat = this.rights[this.selected];
}

By the way, what do
? and % mean in scripting? My scripting reference says:

? = tertiary operator (condition?true-case:false-case)
% = mod; a%b = a - int(a/b)*b;

I don't really understand that...

? is basically a shorthand for some types of if-statements.

PHP Code:


		
			
condition ? value_if_true : value_if_false

i.e.

PHP Code:


		
			
temp.var = "";

if (x > 3) {
  temp.var = "x was more than 3";
} else {
  temp.var = "x was less than 3";
}

is equivalent to

PHP Code:


		
			
temp.var = (x > 3) ? "x was more than 3" : "x was less than 3";

As for modulus, think of it like remainder.

PHP Code:


		
			
3 % 3 // 0
5 % 3 // 2
6 % 5 // 1
10 % 7 // 3